Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$myModel->find(string "value-of-my-primary-key") #1188 #1189

Merged
merged 1 commit into from
Aug 30, 2018
Merged

$myModel->find(string "value-of-my-primary-key") #1188 #1189

merged 1 commit into from
Aug 30, 2018

Conversation

nowackipawel
Copy link
Contributor

adding string as allowed primary key; in current state if you pass string to find method you will get all records instead of desired one.

@nowackipawel
$myModel->find(string "value-of-my-primary-key") codeigniter4#1188
6e1335b 
adding string as allowed primary key; in current state if you pass string to find method you will get all records instead of desired one.
@lonnieezell lonnieezell merged commit 368d305 into codeigniter4:develop Aug 30, 2018
@samsonasik samsonasik mentioned this pull request Aug 31, 2018
Closed
@nowackipawel nowackipawel mentioned this pull request Oct 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nowackipawel @lonnieezell